Skip to content

Create new v8-4.5 branch with V8 4.5.103.24 #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ofrobots wants to merge 7 commits into from
Closed

Create new v8-4.5 branch with V8 4.5.103.24 #2509

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f22484
deps: upgrade V8 to 4.5.103.24
ofrobots Aug 23, 2015
1c4c61e
src: apply debug force load fixups from 41e63fb
ofrobots Aug 23, 2015
60a7587
contextify: ignore getters during initialization
indutny Jul 7, 2015
a959e91
test: fix test-repl-tab-complete.js for V8 4.5
ofrobots Aug 23, 2015
6aad84c
src: enable v8 deprecation warnings and fix them
bnoordhuis Jul 1, 2015
88235a5
src: replace usage of v8::Handle with v8::Local
targos Jul 18, 2015
e0e15c8
src: enable vector ics on arm again
ofrobots Aug 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
contextify: ignore getters during initialization 
The `context_` is not initialized until the `CreateV8Context` will
return. Make sure that it will be empty (by moving away initialization
from constructor) at start, and ignore getter callbacks until it will
have some value.

PR-URL: #2091
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
@indutny @ofrobots
indutny authored and ofrobots committed Aug 24, 2015
commit 60a75879f8321fccb46bc97a993b0552c581ac6b
24 changes: 23 additions & 1 deletion src/node_contextify.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,10 @@ class ContextifyContext {
explicit ContextifyContext(Environment* env, Local<Object> sandbox)
: env_(env),
sandbox_(env->isolate(), sandbox),
context_(env->isolate(), CreateV8Context(env)),
// Wait for sandbox_, proxy_global_, and context_ to die
references_(0) {
context_.Reset(env->isolate(), CreateV8Context(env));

sandbox_.SetWeak(this, WeakCallback<Object, kSandbox>);
sandbox_.MarkIndependent();
references_++;
Expand Down Expand Up @@ -361,6 +362,10 @@ class ContextifyContext {
ContextifyContext* ctx =
Unwrap<ContextifyContext>(args.Data().As<Object>());

// Stil initializing
if (ctx->context_.IsEmpty())
return;

Local<Object> sandbox = PersistentToLocal(isolate, ctx->sandbox_);
MaybeLocal<Value> maybe_rv =
sandbox->GetRealNamedProperty(ctx->context(), property);
Expand Down Expand Up @@ -389,6 +394,10 @@ class ContextifyContext {
ContextifyContext* ctx =
Unwrap<ContextifyContext>(args.Data().As<Object>());

// Stil initializing
if (ctx->context_.IsEmpty())
return;

PersistentToLocal(isolate, ctx->sandbox_)->Set(property, value);
}

Expand All @@ -401,6 +410,10 @@ class ContextifyContext {
ContextifyContext* ctx =
Unwrap<ContextifyContext>(args.Data().As<Object>());

// Stil initializing
if (ctx->context_.IsEmpty())
return;

Local<Object> sandbox = PersistentToLocal(isolate, ctx->sandbox_);
Maybe<PropertyAttribute> maybe_prop_attr =
sandbox->GetRealNamedPropertyAttributes(ctx->context(), property);
Expand Down Expand Up @@ -428,6 +441,11 @@ class ContextifyContext {

ContextifyContext* ctx =
Unwrap<ContextifyContext>(args.Data().As<Object>());

// Stil initializing
if (ctx->context_.IsEmpty())
return;

Local<Object> sandbox = PersistentToLocal(isolate, ctx->sandbox_);

Maybe<bool> success = sandbox->Delete(ctx->context(), property);
Expand All @@ -442,6 +460,10 @@ class ContextifyContext {
ContextifyContext* ctx =
Unwrap<ContextifyContext>(args.Data().As<Object>());

// Stil initializing
if (ctx->context_.IsEmpty())
return;

Local<Object> sandbox = PersistentToLocal(args.GetIsolate(), ctx->sandbox_);
args.GetReturnValue().Set(sandbox->GetPropertyNames());
}
Expand Down