Skip to content

test: increase error information in test-cli-syntax-* #25021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: increase error information in test-cli-syntax-* #25021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: increase error information in test-cli-syntax-* 
If there is an error, but not the error code the test expects, display
more information about the error.
  • Loading branch information
@Trott
Trott committed Dec 13, 2018
commit a7a8f79adad32e39116a503df3b99667982af033
3 changes: 2 additions & 1 deletion test/sequential/test-cli-syntax-bad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ const syntaxErrorRE = /^SyntaxError: \b/m;
const cmd = [node, ..._args].join(' ');
exec(cmd, common.mustCall((err, stdout, stderr) => {
assert.strictEqual(err instanceof Error, true);
assert.strictEqual(err.code, 1);
assert.strictEqual(err.code, 1,
`code ${err.code} !== 1 for error:\n\n${err}`);

// no stdout should be produced
assert.strictEqual(stdout, '');
Expand Down
3 changes: 2 additions & 1 deletion test/sequential/test-cli-syntax-file-not-found.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ const notFoundRE = /^Error: Cannot find module/m;
// stderr should have a module not found error message
assert(notFoundRE.test(stderr), `${notFoundRE} === ${stderr}`);

assert.strictEqual(err.code, 1);
assert.strictEqual(err.code, 1,
`code ${err.code} !== 1 for error:\n\n${err}`);
}));
});
});
3 changes: 2 additions & 1 deletion test/sequential/test-cli-syntax-require.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ const syntaxErrorRE = /^SyntaxError: \b/m;
const cmd = [node, ...args].join(' ');
exec(cmd, common.mustCall((err, stdout, stderr) => {
assert.strictEqual(err instanceof Error, true);
assert.strictEqual(err.code, 1);
assert.strictEqual(err.code, 1,
`code ${err.code} !== 1 for error:\n\n${err}`);

// no stdout should be produced
assert.strictEqual(stdout, '');
Expand Down