Skip to content

build: add a space to clarify skipping crypto msg #25011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

build: add a space to clarify skipping crypto msg #25011

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bead436
build: add a space to clarify skipping crypto msg
danbev Dec 13, 2018
e47291d
squash: add prefix : to skipping message
danbev Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: add a space to clarify skipping crypto msg 
This commit adds a space to the message that is displayed for tests that
are skipped when node was built --without-ssl. For example, this is what
is currently displayed:
"release test-https-agent-additional-optionsSkipping as node was
compiled without crypto support"

After this change this will be:
"release test-https-agent-additional-options Skipping as node was
compiled without crypto support"
  • Loading branch information
@danbev
danbev committed Dec 13, 2018
commit bead4365889b8d0701900d2607c91dbd62f11365
4 changes: 2 additions & 2 deletions test/testpy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,13 @@ def GetCommand(self):
# failure so such tests are also skipped.
if (any(flag.startswith('--inspect') for flag in flags) and
not self.context.v8_enable_inspector):
print('Skipping as node was compiled without inspector support')
print(' Skipping as node was compiled without inspector support')
elif (('--use-bundled-ca' in flags or
'--use-openssl-ca' in flags or
'--tls-v1.0' in flags or
'--tls-v1.1' in flags) and
not self.context.node_has_crypto):
print('Skipping as node was compiled without crypto support')
print(' Skipping as node was compiled without crypto support')
else:
result += flags
files_match = FILES_PATTERN.search(source);
Expand Down