Skip to content

[v8.x backport] Backport tsfn to v8.x #25002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielschulhof wants to merge 10 commits into from
Closed

[v8.x backport] Backport tsfn to v8.x #25002

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2e15372
n-api: add API for asynchronous functions
Jun 17, 2018
b285f1d
n-api: fix compiler warning
cjihrig Jun 29, 2018
7600c04
n-api: guard against cond null dereference
Jul 18, 2018
7965765
src: fix may be uninitialized warning in n-api
mhdawson Jul 19, 2018
46118be
n-api: remove idle_running from TsFn
Jul 27, 2018
35c6b1d
n-api: clean up thread-safe function
Aug 11, 2018
8efb65b
doc: fix optional parameters in n-api.md
Sep 21, 2018
f116dc4
n-api: add missing handle scopes
danbev Oct 31, 2018
e0e1ac2
test: mark test_threadsafe_function/test as flaky
gireeshpunathil Nov 29, 2018
f2e4510
test: fix test-repl-envvars
addaleax Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: mark test_threadsafe_function/test as flaky 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@gireeshpunathil
gireeshpunathil authored and Gabriel Schulhof committed Dec 28, 2018
commit e0e1ac2d0317bd407bf935f1a4ecb338c650f037
11 changes: 11 additions & 0 deletions test/addons-napi/addons-napi.status
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
prefix addons-napi

# To mark a test as flaky, list the test name in the appropriate section
# below, without ".js", followed by ": PASS,FLAKY". Example:
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms

[$system==win32]
# https://github.com/nodejs/node/issues/23621
test_threadsafe_function/test: PASS,FLAKY