Skip to content

util: improve format performance #24981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

util: improve format performance #24981

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d4965
util: improve format performance
BridgeAR Dec 12, 2018
19ad26d
fixup: use node style todo
BridgeAR Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: use node style todo
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 14, 2018
commit 19ad26de372a1cd0be86fc9be67d8459535ffb0d
4 changes: 2 additions & 2 deletions lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ function formatWithOptions(inspectOptions, ...args) {

while (a < args.length) {
const value = args[a];
// TODO: This should apply for all besides strings. Especially BigInt should
// be properly inspected.
// TODO(BridgeAR): This should apply for all besides strings. Especially
// BigInt should be properly inspected.
str += join;
if (typeof value !== 'string' &&
typeof value !== 'boolean' &&
Expand Down