Skip to content

lib: remove internalBinding('config').pendingDeprecation #24962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

lib: remove internalBinding('config').pendingDeprecation #24962

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491fcc8
lib: remove internalBinding('config').pendingDeprecation
joyeecheung Dec 11, 2018
3df97c2
fixup! lib: remove internalBinding('config').pendingDeprecation
joyeecheung Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! lib: remove internalBinding('config').pendingDeprecation
  • Loading branch information
@joyeecheung
joyeecheung committed Dec 14, 2018
commit 3df97c266becc98d24b97609b15f885aa32206a5
5 changes: 3 additions & 2 deletions test/parallel/test-pending-deprecation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const common = require('../common');

const assert = require('assert');
const fork = require('child_process').fork;
const { getOptionValue } = require('internal/options');

function message(name) {
return `${name} did not affect getOptionValue('--pending-deprecation')`;
Expand All @@ -24,15 +25,15 @@ switch (process.argv[2]) {
case 'env':
case 'switch':
assert.strictEqual(
require('internal/options').getOptionValue('--pending-deprecation'),
getOptionValue('--pending-deprecation'),
true
);
break;
default:
// Verify that the flag is off by default.
const envvar = process.env.NODE_PENDING_DEPRECATION;
assert.strictEqual(
require('internal/options').getOptionValue('--pending-deprecation'),
getOptionValue('--pending-deprecation'),
!!(envvar && envvar[0] === '1')
);

Expand Down