Skip to content

lib: ensure readable stream flows to end #24918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rantanen wants to merge 8 commits into from
+157 −4
Closed

lib: ensure readable stream flows to end #24918

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6685360
lib: ensure readable stream flows to end
Rantanen Dec 9, 2018
a7cc7a3
lib: add parens to while condition
Rantanen Dec 10, 2018
a293112
lib: clarify maybeReadMore_ loop conditions
Rantanen Dec 11, 2018
5d230ab
lib: improve variable scoping in maybeReadMore
Rantanen Dec 11, 2018
7cb1ccc
lib: clarify hwm-0-async test description
Rantanen Dec 11, 2018
30f6a50
lib: add readable stream flow/no-flow mixed test
Rantanen Dec 11, 2018
216f5e0
lib: simplify the no-flow data test
Rantanen Dec 13, 2018
f2ab091
lib: implement review suggestions
Rantanen Dec 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: implement review suggestions
  • Loading branch information
@Rantanen
Rantanen committed Dec 13, 2018
commit f2ab091a2a623a039b29bee605ff75ae3907bc4b
17 changes: 13 additions & 4 deletions test/parallel/test-stream-readable-hwm-0-no-flow-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@ r.on('end', common.mustCall(() => {
}));
assert.strictEqual(r.readableFlowing, false);

setTimeout(() => {
// The stream emits the events asynchronously but that's not guaranteed to
// happen on the next tick (especially since the _read implementation above
// uses process.nextTick).
//
// We use setImmediate here to give the stream enough time to emit all the
// events it's about to emit.
setImmediate(() => {

// Only the _read, push, readable calls have happened. No data must be
// emitted yet.
Expand All @@ -61,8 +67,11 @@ setTimeout(() => {
// Note: This 'null' signals "no data available". It isn't the end-of-stream
// null value as the stream doesn't know yet that it is about to reach the
// end.
//
// Using setImmediate again to give the stream enough time to emit all the
// events it wants to emit.
assert.strictEqual(r.read(), null);
setTimeout(() => {
setImmediate(() => {

// There's a new 'readable' event after the data has been pushed.
// The 'end' event will be emitted only after a 'read()'.
Expand Down Expand Up @@ -91,5 +100,5 @@ setTimeout(() => {
['_read:a', 'push:a', 'readable', 'data:a',
'_read:null', 'push:null', 'readable', 'end']);
});
}, 1);
}, 1);
});
});