Skip to content

deps: update V8 to 7.2 #24875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 10 commits into from
Closed

deps: update V8 to 7.2 #24875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7d29926
deps: update V8 to 7.2.502.21
targos Jan 20, 2019
bb0ffe7
build: reset embedder string to "-node.0"
targos Jan 20, 2019
a9cd973
src: update NODE_MODULE_VERSION to 69
targos Jan 20, 2019
d1486e9
deps: sync V8 gypfiles with 7.2
targos Oct 10, 2018
20721dc
deps: bump minimum icu version to 63
ryzokuken Nov 8, 2018
8c3a8c8
test: remove apply calls over 65534 arg limit
psmarshall Nov 22, 2018
c04c8a2
test: update test-v8-stats
targos Nov 23, 2018
061446d
deps: backport ef8323ea8 from upstream V8
addaleax Jan 24, 2019
f9142b8
deps: cherry-pick fc0ddf5 from upstream V8
addaleax Jan 24, 2019
85ffec2
deps: backport bits of 9302db480e8 from upstream V8
addaleax Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: remove apply calls over 65534 arg limit
  • Loading branch information
@psmarshall @targos
psmarshall authored and targos committed Jan 20, 2019
commit 8c3a8c89b33321941d513698d64c2a855a35976d
5 changes: 3 additions & 2 deletions test/parallel/test-buffer-includes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,9 @@ assert(asciiString.includes('leb', 0));

// Search in string containing many non-ASCII chars.
const allCodePoints = [];
for (let i = 0; i < 65536; i++) allCodePoints[i] = i;
const allCharsString = String.fromCharCode.apply(String, allCodePoints);
for (let i = 0; i < 65534; i++) allCodePoints[i] = i;
const allCharsString = String.fromCharCode.apply(String, allCodePoints) +
String.fromCharCode(65534, 65535);
const allCharsBufferUtf8 = Buffer.from(allCharsString);
const allCharsBufferUcs2 = Buffer.from(allCharsString, 'ucs2');

Expand Down
5 changes: 3 additions & 2 deletions test/parallel/test-buffer-indexof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,9 @@ assert.strictEqual(asciiString.indexOf('leb', 0), 3);

// Search in string containing many non-ASCII chars.
const allCodePoints = [];
for (let i = 0; i < 65536; i++) allCodePoints[i] = i;
const allCharsString = String.fromCharCode.apply(String, allCodePoints);
for (let i = 0; i < 65534; i++) allCodePoints[i] = i;
const allCharsString = String.fromCharCode.apply(String, allCodePoints) +
String.fromCharCode(65534, 65535);
const allCharsBufferUtf8 = Buffer.from(allCharsString);
const allCharsBufferUcs2 = Buffer.from(allCharsString, 'ucs2');

Expand Down