Skip to content

bootstrap: make Buffer and process non-enumerable #24874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 4 commits into from
Closed

bootstrap: make Buffer and process non-enumerable #24874

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e76fc8c
bootstrap: make Buffer and process non-enumerable
BridgeAR Dec 5, 2018
daa8808
fixup: fix test with DTRACE globals
BridgeAR Dec 10, 2018
792d4a6
fixup: use strings, not the functions
BridgeAR Dec 10, 2018
4729c69
fixup: unordered entries
BridgeAR Dec 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: fix test with DTRACE globals
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 10, 2018
commit daa88083a43ee69b8b99dd025e6a0da3718c55ae
20 changes: 15 additions & 5 deletions test/parallel/test-global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,18 +40,28 @@ builtinModules.forEach((moduleName) => {
}
});

assert.deepStrictEqual(
Object.keys(global),
[
{
const expected = [
'global',
'clearImmediate',
'clearInterval',
'clearTimeout',
'setImmediate',
'setInterval',
'setTimeout'
]
);
];
if (global.DTRACE_HTTP_SERVER_RESPONSE) {
expected.unshift(
DTRACE_HTTP_SERVER_RESPONSE,
DTRACE_HTTP_SERVER_REQUEST,
DTRACE_HTTP_CLIENT_RESPONSE,
DTRACE_HTTP_CLIENT_REQUEST,
DTRACE_NET_STREAM_END,
DTRACE_NET_SERVER_CONNECTION
);
}
assert.deepStrictEqual(Object.keys(global), expected);
}

common.allowGlobals('bar', 'foo');

Expand Down