Skip to content

assert,util: harden comparison #24831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 4 commits into from
Closed

assert,util: harden comparison #24831

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ac6bd7
assert,util: harden comparison
BridgeAR Dec 3, 2018
e9c42ce
fixup
BridgeAR Dec 4, 2018
0af2cbd
fixup: fix typo
addaleax Dec 6, 2018
e0bf44c
fixup: use clearer name and simplify statement
BridgeAR Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 4, 2018
commit e9c42cebd9634abc0f5b33b350f5c65cd8d55ed8
2 changes: 1 addition & 1 deletion test/parallel/test-assert-deep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,7 +997,7 @@ assert.throws(
assert.deepStrictEqual(a, b);
}

// Verify that extra keys will be tested for when
// Verify that extra keys will be tested for when using fake arrays.
{
const a = {
0: 1,
Expand Down