Skip to content

[8.x] assert: revert breaking change #24786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

[8.x] assert: revert breaking change #24786

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd7004f
assert: revert breaking change
BridgeAR Dec 2, 2018
3e6e200
fixup
BridgeAR Dec 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 2, 2018
commit 3e6e2000a7dc14c299d11d5df201d39887fd39bf
2 changes: 1 addition & 1 deletion test/parallel/test-assert-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ common.crashOnUnhandledRejection();
assert(err instanceof assert.AssertionError,
`${err.name} is not instance of AssertionError`);
assert.strictEqual(err.code, 'ERR_ASSERTION');
assert(/^Got unwanted rejection\.\n$/.test(err.message));
assert(/^Got unwanted rejection\.$/.test(err.message));
assert.strictEqual(err.operator, 'doesNotReject');
assert.ok(!err.stack.includes('at Function.doesNotReject'));
return true;
Expand Down