Skip to content

src: move version metadata into node_metadata{.h, .cc} #24774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

src: move version metadata into node_metadata{.h, .cc} #24774

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af8a225
src: move READONLY_* macros into util.h
joyeecheung Nov 29, 2018
1df332a
src: move version metadata into node_metadata{.h, .cc}
joyeecheung Dec 1, 2018
6f998d2
fixup! src: move version metadata into node_metadata{.h, .cc}
joyeecheung Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: move version metadata into node_metadata{.h, .cc}
  • Loading branch information
@joyeecheung
joyeecheung committed Dec 3, 2018
commit 6f998d2197dcf2278a91134f8d9827ef960b7329
4 changes: 2 additions & 2 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@
'src/node_http2.cc',
'src/node_i18n.cc',
'src/node_messaging.cc',
'src/node_metadata.cc',
'src/node_native_module.cc',
'src/node_options.cc',
'src/node_os.cc',
Expand All @@ -370,7 +371,6 @@
'src/node_url.cc',
'src/node_util.cc',
'src/node_v8.cc',
'src/node_metadata.cc',
'src/node_watchdog.cc',
'src/node_worker.cc',
'src/node_zlib.cc',
Expand Down Expand Up @@ -428,6 +428,7 @@
'src/node_i18n.h',
'src/node_internals.h',
'src/node_messaging.h',
'src/node_metadata.h',
'src/node_mutex.h',
'src/node_native_module.h',
'src/node_object_wrap.h',
Expand All @@ -443,7 +444,6 @@
'src/node_union_bytes.h',
'src/node_url.h',
'src/node_version.h',
'src/node_metadata.h',
'src/node_watchdog.h',
'src/node_worker.h',
'src/pipe_wrap.h',
Expand Down