Skip to content

http2: make compat writeHead not crash if the stream is destroyed #24723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 2 commits into from
+34 −0
Closed

http2: make compat writeHead not crash if the stream is destroyed #24723

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69e283e
http2: make compat writeHead not crash if the stream is destroyed
mcollina Nov 29, 2018
c54500b
Update test/parallel/test-http2-compat-write-head-destroyed.js
richardlau Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/parallel/test-http2-compat-write-head-destroyed.js 
Co-Authored-By: mcollina <matteo.collina@gmail.com>
  • Loading branch information
@richardlau @mcollina
richardlau and mcollina authored Nov 29, 2018
commit c54500b4c74aedff4e4460917464ee27a991b880
2 changes: 1 addition & 1 deletion test/parallel/test-http2-compat-write-head-destroyed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');

// Check that writeHead, write and end do not crash in compatibikity mode
// Check that writeHead, write and end do not crash in compatibility mode

const server = http2.createServer(common.mustCall((req, res) => {
// destroy the stream first
Expand Down