Skip to content

test: replace anonymous functions with arrows #24691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Shubhamurkade wants to merge 2 commits into from
Closed

test: replace anonymous functions with arrows #24691

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5a8c7f
test: replace anonymous functions with arrows
Shubhamurkade Nov 27, 2018
ee74c81
test: revert arrow function for echoServer.on
Shubhamurkade Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: replace anonymous functions with arrows
  • Loading branch information
@Shubhamurkade
Shubhamurkade committed Nov 28, 2018
commit b5a8c7ff38065c9d5d4c23855935035df36a73f3
6 changes: 3 additions & 3 deletions test/parallel/test-net-persistent-ref-unref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const net = require('net');
const { internalBinding } = require('internal/test/binding');
const TCPWrap = internalBinding('tcp_wrap').TCP;

const echoServer = net.createServer(function(conn) {
const echoServer = net.createServer((conn) => {
conn.end();
});

Expand All @@ -29,12 +29,12 @@ TCPWrap.prototype.unref = function() {

echoServer.listen(0);

echoServer.on('listening', function() {
echoServer.on('listening', () => {
const sock = new net.Socket();
sock.unref();
sock.ref();
sock.connect(this.address().port);
sock.on('end', function() {
sock.on('end', () => {
assert.strictEqual(refCount, 0);
echoServer.close();
});
Expand Down