Skip to content

test: verify order of error in h2 server stream #24685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 2 commits into from
+43 −0
Closed

test: verify order of error in h2 server stream #24685

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ed353
test: verify order of error in h2 server stream
MylesBorins Nov 27, 2018
ccf039e
fixup: address nits
MylesBorins Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions test/parallel/test-http2-error-order.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

const assert = require('assert');
const { createServer, connect } = require('http2');

const messages = [];
const expected = [
'Stream:created',
'Stream:error',
'Stream:close',
'Request:error'
];

const server = createServer();

server.on('stream', (stream) => {
messages.push('Stream:created');
stream
.on('close', () => messages.push('Stream:close'))
.on('error', (err) => messages.push('Stream:error'))
.respondWithFile('dont exist');
});

server.listen(8000);
Comment thread
MylesBorins marked this conversation as resolved.
Outdated

const client = connect('http://localhost:8000');
const req = client.request();

req.on('response', common.mustNotCall());

req.on('error', () => {
messages.push('Request:error');
client.close();
});

client.on('close', () => {
Comment thread
MylesBorins marked this conversation as resolved.
Outdated
assert.deepStrictEqual(messages, expected);
server.close();
});