Skip to content

doc: revise accepting-modifications in guide #24650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

doc: revise accepting-modifications in guide #24650

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24e7827
doc: revise accepting-modifications in guide
Trott Nov 26, 2018
44ca697
fixup! doc: revise accepting-modifications in guide
Trott Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: revise accepting-modifications in guide 
Revise the "Accepting Modifications" section of the Collaborator Guide.
  • Loading branch information
@Trott
Trott committed Nov 28, 2018
commit 24e7827ad60679240c0f7bc680be1f5ab664f5a8
9 changes: 3 additions & 6 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,9 @@ to land but is [author ready](#author-ready-pull-requests), add the

## Accepting Modifications

All modifications to the Node.js code and documentation should be performed via
GitHub pull requests, including modifications by Collaborators and TSC members.
A pull request must be reviewed, and must also be tested with CI, before being
landed into the codebase. There may be exceptions to the latter (the changed
code cannot be tested with a CI or similar). If that is the case, please leave a
comment that explains why the PR does not require a CI run.
All modifications to Node.js start as GitHub pull requests. This includes
Copy link
Copy Markdown
Member

@richardlau richardlau Nov 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is less accurate than the original. Some modifications start from issues, even if they ultimately end up as being made via pull requests.

modifications by Collaborators (including TSC members). A pull request must pass
code review and CI before landing into the codebase.

### Code Reviews

Expand Down