Skip to content

src: simplify uptime and ppid return values #24562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjihrig wants to merge 1 commit into from
Closed

src: simplify uptime and ppid return values #24562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: simplify uptime and ppid return values 
This commit removes extraneous wrapping of return values
in Uptime() and GetParentProcessId().
  • Loading branch information
@cjihrig
cjihrig committed Nov 22, 2018
commit 06202c022cba79ceb73b2e415e4dbe3ca930a565
5 changes: 2 additions & 3 deletions src/node_process.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ using v8::Integer;
using v8::Isolate;
using v8::Local;
using v8::Name;
using v8::Number;
using v8::PropertyCallbackInfo;
using v8::String;
using v8::Uint32;
Expand Down Expand Up @@ -259,7 +258,7 @@ void Uptime(const FunctionCallbackInfo<Value>& args) {
uv_update_time(env->event_loop());
uptime = uv_now(env->event_loop()) - prog_start_time;

args.GetReturnValue().Set(Number::New(env->isolate(), uptime / 1000));
args.GetReturnValue().Set(uptime / 1000);
}


Expand Down Expand Up @@ -790,7 +789,7 @@ void EnvEnumerator(const PropertyCallbackInfo<Array>& info) {

void GetParentProcessId(Local<Name> property,
const PropertyCallbackInfo<Value>& info) {
info.GetReturnValue().Set(Integer::New(info.GetIsolate(), uv_os_getppid()));
info.GetReturnValue().Set(uv_os_getppid());
}

void GetActiveRequests(const FunctionCallbackInfo<Value>& args) {
Expand Down