Skip to content

http2: fix session[kSession] undefined issue #24547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leeight wants to merge 2 commits into from
Closed

http2: fix session[kSession] undefined issue #24547

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e5e01c
http2: fix session[kSession] undefined issue
leeight Nov 21, 2018
90e83cd
https: test/parallel/test-http2-server-session-destroy.js
oyyd Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http2: fix session[kSession] undefined issue 
`finishSessionDestroy` already done session cleaning up.

Fix: #24546
  • Loading branch information
@leeight
leeight committed Nov 22, 2018
commit 8e5e01cd8a8ca1962625dd041b9cfb39370085b3
1 change: 1 addition & 0 deletions lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1989,6 +1989,7 @@ class Http2Stream extends Duplex {
// attempt to gracefully close the session.
const state = this[kState];
if (this.headersSent &&
this[kSession] &&
this[kSession][kType] === NGHTTP2_SESSION_SERVER &&
!(state.flags & STREAM_FLAGS_HAS_TRAILERS) &&
!state.didRead &&
Expand Down
16 changes: 16 additions & 0 deletions test/parallel/test-http2-server-session-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');

const server = h2.createServer();
server.listen(0, common.mustCall(() => {
h2.connect(`http://localhost:${server.address().port}`, (session) => {
Comment thread
leeight marked this conversation as resolved.
Outdated
session.request({ ':method': 'POST' }).end(common.mustCall(() => {
session.destroy();
server.close();
}));
});
}));