Skip to content

changing closure function to arrow #24489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manilson wants to merge 1 commit into from
Closed

changing closure function to arrow #24489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: replace closure with arrow function
  • Loading branch information
@manilson
Maya Anilson authored and manilson committed Nov 20, 2018
commit 97a7d7fe1c835743c1ad2e538c960b6c834a36d6
26 changes: 13 additions & 13 deletions test/pummel/test-net-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,46 +29,46 @@ let starttime = null;
let timeouttime = null;
const timeout = 1000;

const echo_server = net.createServer(function(socket) {
const echo_server = net.createServer((socket) => {
socket.setTimeout(timeout);

socket.on('timeout', function() {
socket.on('timeout', () => {
console.log('server timeout');
timeouttime = new Date();
console.dir(timeouttime);
socket.destroy();
});

socket.on('error', function(e) {
socket.on('error', (e) => {
throw new Error(
'Server side socket should not get error. We disconnect willingly.');
});

socket.on('data', function(d) {
socket.on('data', (d) => {
console.log(d);
socket.write(d);
});

socket.on('end', function() {
socket.on('end', () => {
socket.end();
});
});

echo_server.listen(common.PORT, function() {
echo_server.listen(common.PORT, () => {
console.log(`server listening at ${common.PORT}`);

const client = net.createConnection(common.PORT);
client.setEncoding('UTF8');
client.setTimeout(0); // disable the timeout for client
client.on('connect', function() {
client.on('connect', () => {
console.log('client connected.');
client.write('hello\r\n');
});

client.on('data', function(chunk) {
client.on('data', (chunk) => {
assert.strictEqual(chunk, 'hello\r\n');
if (exchanges++ < 5) {
setTimeout(function() {
setTimeout(() => {
console.log('client write "hello"');
client.write('hello\r\n');
}, 500);
Expand All @@ -81,22 +81,22 @@ echo_server.listen(common.PORT, function() {
}
});

client.on('timeout', function() {
client.on('timeout', () => {
throw new Error("client timeout - this shouldn't happen");
});

client.on('end', function() {
client.on('end', () => {
console.log('client end');
client.end();
});

client.on('close', function() {
client.on('close', () => {
console.log('client disconnect');
echo_server.close();
});
});

process.on('exit', function() {
process.on('exit', () => {
assert.ok(starttime != null);
assert.ok(timeouttime != null);

Expand Down