Skip to content

test: refactor test-child-process-env to use arrow functions #24482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sagirk wants to merge 3 commits into from
Closed

test: refactor test-child-process-env to use arrow functions #24482

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0767eba
test: refactor test-child-process-env to use arrow functions
sagirk Nov 19, 2018
91fa0e1
test: wrap functions containing assertions inside a `common.mustCall`
sagirk Nov 20, 2018
dc4bdab
Revert "test: wrap functions containing assertions inside a `common.m…
sagirk Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: wrap functions containing assertions inside a common.mustCall
  • Loading branch information
@sagirk
sagirk committed Nov 21, 2018
commit 91fa0e1a617ff6aec4904dbe738b0769afc3e408
4 changes: 2 additions & 2 deletions test/parallel/test-child-process-env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ child.stdout.on('data', (chunk) => {
response += chunk;
});

process.on('exit', () => {
process.on('exit', common.mustCall(() => {
assert.ok(response.includes('HELLO=WORLD'));
assert.ok(response.includes('FOO=BAR'));
assert.ok(!response.includes('UNDEFINED=undefined'));
assert.ok(response.includes('NULL=null'));
assert.ok(response.includes(`EMPTY=${os.EOL}`));
});
}));