Skip to content

src: elevate namespaces for repeated entities #24475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SarathGovind wants to merge 4 commits into from
Closed

src: elevate namespaces for repeated entities #24475

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b18b300
src: elevate namespaces for repeated entities
SarathGovind Nov 19, 2018
b916604
fixup: remove unwanted changes
SarathGovind Nov 19, 2018
9a5f109
fixup: remove unwanted v8::Message delcaration
SarathGovind Nov 19, 2018
2817ac0
made changes in Local<Function>
SarathGovind Nov 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: elevate namespaces for repeated entities
  • Loading branch information
@SarathGovind
SarathGovind committed Nov 19, 2018
commit b18b300b1f6a9db83caef72adc631677559dda32
6 changes: 4 additions & 2 deletions src/inspector_js_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ namespace {

using v8::Boolean;
using v8::Context;
using v8::Environment;
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::FunctionTemplate;
using v8::HandleScope;
using v8::Isolate;
using v8::Local;
using v8::MaybeLocal;
using v8::Message;
using v8::NewStringType;
using v8::Object;
using v8::String;
Expand Down Expand Up @@ -224,9 +226,9 @@ static void RegisterAsyncHookWrapper(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

CHECK(args[0]->IsFunction());
v8::Local<v8::Function> enable_function = args[0].As<Function>();
Local<function> enable_function = args[0].As<Function>();
CHECK(args[1]->IsFunction());
v8::Local<v8::Function> disable_function = args[1].As<Function>();
Local<Function> disable_function = args[1].As<Function>();
env->inspector_agent()->RegisterAsyncHook(env->isolate(),
enable_function, disable_function);
}
Expand Down