Skip to content

doc,meta: add issue template for flaky tests #24450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 2 commits into from
Closed

doc,meta: add issue template for flaky tests #24450

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d5284d
doc,meta: add issue template for flaky tests
refack Nov 17, 2018
f7187f5
fixup! simplify
refack Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc,meta: add issue template for flaky tests
  • Loading branch information
@refack
refack committed Nov 17, 2018
commit 2d5284dd522473f684050ba8694ccdc9a48e9841
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/5-flaky-test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
name: "\U0001F4AB Found a flaky test?"
about: Please provide information about the failure.

---
<!--
Thank you for reporting a possible flaky test in Node.js.

Please fill in as much of the template below as you can.

-->
* test file - [NAME_OF_TEST_WITH_SUITE (e.g. parallel/test-https)](https://github.com/nodejs/node/blob/master/test/NAME_OF_TEST_WITH_SUITE.js)
* ci job - [CI_JOB_DESCRIPTOR (e.g. aix/21613)](https://ci.nodejs.org/job/node-test-CI_JOB_DESCRIPTOR)
* ci worker - [CI_WORKER_NAME](https://ci.nodejs.org/computer/CI_WORKER_NAME/)
* output:
```
CI console output for the failing test.
Or content of JUnit test details page.
Note: should be indented with 2 spaces to align with * bullet point.
Copy link
Copy Markdown
Member

@Trott Trott Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this. Having to indent output by two spaces can be annoying/tedious. It's OK if it's not indented (or does that cause a big problem--seems mostly aesthetics)?

```