Skip to content

Fixes: test: fixed the arguments order in #24227 #24413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kanishk30 wants to merge 3 commits into from
Closed

Fixes: test: fixed the arguments order in #24227 #24413

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa38efa
Fixes: test: fixed the arguments order in #24227
kanishk30 Nov 17, 2018
4f0870e
test: fix arguments order in napi test_exception
kanishk30 Nov 17, 2018
9d62ed9
Merge branch 'ka-node' of https://github.com/kanishk30/node into ka-node
kanishk30 Nov 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix arguments order in napi test_exception
  • Loading branch information
@kanishk30
kanishk30 committed Nov 17, 2018
commit 4f0870ea13e194e680a2e875df385b26eaedd12e
2 changes: 1 addition & 1 deletion test/addons-napi/test_exception/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const test_exception = (function() {

// Test that the native side successfully captures the exception
let returnedError = test_exception.returnException(throwTheError);
assert.strictEqual(theError, returnedError);
assert.strictEqual(returnedError, theError);

// Test that the native side passes the exception through
assert.throws(
Expand Down