Skip to content

fs: flip value of isOpen #24390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dexterleng wants to merge 2 commits into from
Closed

fs: flip value of isOpen #24390

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b9808
fs: flip value of isOpen
Nov 16, 2018
9392d67
fs: inline typeof check
Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fs: inline typeof check
  • Loading branch information
dexterleng committed Nov 16, 2018
commit 9392d6733f38170da428b044402fa58ad8f1e053
3 changes: 1 addition & 2 deletions lib/internal/fs/streams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,7 @@ ReadStream.prototype._read = function(n) {
};

ReadStream.prototype._destroy = function(err, cb) {
const isOpen = typeof this.fd === 'number';
if (!isOpen) {
if (typeof this.fd !== 'number') {
this.once('open', closeFsStream.bind(null, this, cb, err));
return;
}
Expand Down