Skip to content

docs: edit LTS labels section #24369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cfanoulis wants to merge 7 commits into from
Closed

docs: edit LTS labels section #24369

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5fa001c
doc: add v8 and v10 tags in the LTS section
cfanoulis Nov 14, 2018
10a6a35
http: else case is not reachable
Nov 6, 2018
af864b8
test: deep object to table not covered
ovhemert Nov 8, 2018
92beff9
Revert "util: change util.inspect depth default"
devsnek Nov 12, 2018
887c490
timers: fix priority queue removeAt
apapirovski Nov 12, 2018
37205b3
lib: improved conditional check in zlib
dYale Nov 6, 2018
c0cd39b
test: add typeerror for vm/compileFunction params
dYale Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lib: improved conditional check in zlib 
PR-URL: #24190
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@dYale @cfanoulis
dYale authored and cfanoulis committed Nov 15, 2018
commit 37205b3c238bbe5631c8072806d5fa38cb07a45a
14 changes: 6 additions & 8 deletions lib/zlib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,7 @@ Object.defineProperty(Zlib.prototype, 'bytesRead', {
// `params()` function should not happen while a write is currently in progress
// on the threadpool.
function paramsAfterFlushCallback(level, strategy, callback) {
if (!this._handle)
assert(false, 'zlib binding closed');
assert(this._handle, 'zlib binding closed');
this._handle.params(level, strategy);
if (!this._hadError) {
this._level = level;
Expand Down Expand Up @@ -507,8 +506,8 @@ function processChunkSync(self, chunk, flushFlag) {
else
buffers.push(out);
nread += out.byteLength;
} else if (have < 0) {
assert(false, 'have should not go down');
} else {
assert(have === 0, 'have should not go down');
}

// exhausted the output buffer, or used all the input create a new one.
Expand Down Expand Up @@ -545,8 +544,7 @@ function processChunkSync(self, chunk, flushFlag) {

function processChunk(self, chunk, flushFlag, cb) {
var handle = self._handle;
if (!handle)
assert(false, 'zlib binding closed');
assert(handle, 'zlib binding closed');

handle.buffer = chunk;
handle.cb = cb;
Expand Down Expand Up @@ -593,8 +591,8 @@ function processCallback() {
var out = self._outBuffer.slice(self._outOffset, self._outOffset + have);
self._outOffset += have;
self.push(out);
} else if (have < 0) {
assert(false, 'have should not go down');
} else {
assert(have === 0, 'have should not go down');
}

if (self.destroyed) {
Expand Down