Skip to content

lib: fix - invalid timer priority queue order #24318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mareksrom wants to merge 2 commits into from
Closed

lib: fix - invalid timer priority queue order #24318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa558e6
lib: fix - invalid timer priority queue order
mareksrom Nov 12, 2018
04f408b
lib: fix test build inconsistencies
mareksrom Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: fix test build inconsistencies
  • Loading branch information
@mareksrom
mareksrom committed Nov 12, 2018
commit 04f408b2649dcd4b5bf3bfa8a1adc67b97c8982c
1 change: 0 additions & 1 deletion lib/internal/priority_queue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ module.exports = class PriorityQueue {
updateAt(pos) {
const heap = this[kHeap];
const item = heap[pos];
const compare = this[kCompare];
this.removeAt(pos);
this.insert(item);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright Joyent, Inc. and other Node contributors.
// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
Expand Down