Skip to content

test: fix flaky test-vm-timeout-escape-queuemicrotask #24296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: fix flaky test-vm-timeout-escape-queuemicrotask #24296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-vm-timeout-escape-queuemicrotask 
Use a larger timeout on slower platforms so that the timeout doesn't
fire before the error condition occurs.
  • Loading branch information
@Trott
Trott committed Nov 11, 2018
commit 3d2ad74ee04a8c8ae668ebdfee3f1309775532ee
1 change: 0 additions & 1 deletion test/known_issues/known_issues.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ prefix known_issues

[$system==linux]
test-vm-timeout-escape-promise: PASS,FLAKY
test-vm-timeout-escape-queuemicrotask: PASS,FLAKY

[$system==macos]

Expand Down
4 changes: 2 additions & 2 deletions test/known_issues/test-vm-timeout-escape-queuemicrotask.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// Promises, nextTick, and queueMicrotask allow code to escape the timeout
// set for runInContext, runInNewContext, and runInThisContext

require('../common');
const common = require('../common');
const assert = require('assert');
const vm = require('vm');

Expand Down Expand Up @@ -32,7 +32,7 @@ assert.throws(() => {
queueMicrotask,
loop
},
{ timeout: 5 }
{ timeout: common.platformTimeout(5) }
);
}, {
code: 'ERR_SCRIPT_EXECUTION_TIMEOUT',
Expand Down