Skip to content

net: always invoke after-write callback #24291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

net: always invoke after-write callback #24291

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a753716
net: always invoke after-write callback
addaleax Nov 10, 2018
c54ef53
fixup! net: always invoke after-write callback
addaleax Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! net: always invoke after-write callback
  • Loading branch information
@addaleax
addaleax committed Nov 11, 2018
commit c54ef5348516037de0c8f4a788279c7430d85c80
2 changes: 1 addition & 1 deletion test/parallel/test-tls-invoke-queued.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const server = tls.createServer({
c.write('world!', null, common.mustCall(function() {
c.destroy();
}));
// Data on next _write() will be written but callback will not be invoked
// Data on next _write() will be written, and the cb will still be invoked
c.write(' gosh', null, common.mustCall());
}));

Expand Down