Skip to content

benchmark: support more options in startup benchmark #24220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

benchmark: support more options in startup benchmark #24220

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab62bc9
benchmark: support more options in startup benchmark
joyeecheung Nov 6, 2018
11ddcdb
fixup! benchmark: support more options in startup benchmark
joyeecheung Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! benchmark: support more options in startup benchmark
  • Loading branch information
@joyeecheung
joyeecheung committed Nov 8, 2018
commit 11ddcdbbdb64286e6cf9024e3f9782deb89bb5da
8 changes: 4 additions & 4 deletions benchmark/misc/startup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ const bench = common.createBenchmark(main, {
flags: ['--expose-internals', '--experimental-worker'] // for workers
});

function spwanProcess(script) {
function spawnProcess(script) {
const cmd = process.execPath || process.argv[0];
const argv = ['--expose-internals', script];
return spawn(cmd, argv);
}

function spwanWorker(script) {
function spawnWorker(script) {
return new Worker(script, { stderr: true, stdout: true });
}

Expand Down Expand Up @@ -68,9 +68,9 @@ function main({ dur, script, mode }) {
if (mode === 'worker') {
Worker = require('worker_threads').Worker;
bench.start();
start(state, script, bench, spwanWorker);
start(state, script, bench, spawnWorker);
} else {
bench.start();
start(state, script, bench, spwanProcess);
start(state, script, bench, spawnProcess);
}
}