Skip to content

test: add typeerror for vm/compileFunction params #24179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dYale wants to merge 2 commits into from
Closed

test: add typeerror for vm/compileFunction params #24179

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a401f13
test: add typeerror for vm/compileFunction params
dYale Nov 6, 2018
c2f9eb9
test: fix linter errors for compileFunction params test
dYale Nov 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix linter errors for compileFunction params test
  • Loading branch information
@dYale
dYale committed Nov 14, 2018
commit c2f9eb930f1ba7edc3c49d8271ee9ee2a0acef9e
26 changes: 13 additions & 13 deletions test/parallel/test-vm-basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,19 +209,19 @@ const vm = require('vm');
}
);

// Testing for non Array type-based failures
[Boolean(), Number(), null, Object(), Symbol(), {}].forEach(
(value) => {
common.expectsError(() => {
vm.compileFunction('', value);
}, {
type: TypeError,
code: 'ERR_INVALID_ARG_TYPE',
message: 'The "params" argument must be of type Array. '
+ `Received type ${typeof value}`
});
}
);
// Testing for non Array type-based failures
[Boolean(), Number(), null, Object(), Symbol(), {}].forEach(
(value) => {
common.expectsError(() => {
vm.compileFunction('', value);
}, {
type: TypeError,
code: 'ERR_INVALID_ARG_TYPE',
message: 'The "params" argument must be of type Array. ' +
`Received type ${typeof value}`
});
}
);

assert.strictEqual(
vm.compileFunction(
Expand Down