Skip to content

test: test dgram socket prints deprecation warnings #24177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rpamely wants to merge 1 commit into from
Closed

test: test dgram socket prints deprecation warnings #24177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: test dgram socket prints deprecation warnings 
Adds tests assert the deprecated properties
and methods in the dgram socket warn. It
runs each test in a separate child process
since each deprecation will only warn once.
  • Loading branch information
@rpamely
rpamely committed Nov 6, 2018
commit f658dc0089624a12ec00889de9377fc54ce97c1b
84 changes: 84 additions & 0 deletions test/parallel/test-dgram-deprecation-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
'use strict';

const assert = require('assert');
const common = require('../common');
const dgram = require('dgram');
const fork = require('child_process').fork;

const sock = dgram.createSocket('udp4');

const testNumber = parseInt(process.argv[2], 10);

const propertiesToTest = [
'_handle',
'_receiving',
'_bindState',
'_queue',
'_reuseAddr'
];

const methodsToTest = [
'_healthCheck',
'_stopReceiving'
];

const propertyCases = propertiesToTest.map((propName) => {
return [
() => {
// Test property getter
common.expectWarning(
'DeprecationWarning',
`Socket.prototype.${propName} is deprecated`,
'DEP0112'
);
sock[propName];
},
() => {
// Test property setter
common.expectWarning(
'DeprecationWarning',
`Socket.prototype.${propName} is deprecated`,
'DEP0112'
);
sock[propName] = null;
}
];
});

const methodCases = methodsToTest.map((propName) => {
return () => {
common.expectWarning(
'DeprecationWarning',
`Socket.prototype.${propName}() is deprecated`,
'DEP0112'
);
sock[propName]();
};
});

const cases = [].concat(
...propertyCases,
...methodCases
);

// If we weren't passed a test ID then we need to spawn all of the cases.
// We run the cases in child processes since deprecations print once.
if (Number.isNaN(testNumber)) {
const children = cases.map((_case, i) =>
fork(process.argv[1], [ String(i) ]));

children.forEach((child) => {
child.on('close', (code) => {
// Pass on child exit code
if (code > 0) {
process.exit(code);
}
});
});

return;
}

// We were passed a test ID - run the test case
assert.ok(cases[testNumber]);
cases[testNumber]();