Skip to content

test: switch arguments in strictEqual #24141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mthpvg wants to merge 1 commit into from
Closed

test: switch arguments in strictEqual #24141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: switch arguments in strictEqual 
In the `test/parallel/test-vm-create-and-run-in-context.js`
test the actual and expected arguments in the `assert.strictEqual()`
call on line 32 are in the wrong order and they have to be switched
around.

:100644 100644 8f4ce72... bd746cf... M	test/parallel/test-vm-create-and-run-in-context.js
  • Loading branch information
@mthpvg
mthpvg committed Nov 6, 2018
commit fe994aaa3641272d4a453241c756d0dbfaa7b7e1
2 changes: 1 addition & 1 deletion test/parallel/test-vm-create-and-run-in-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const vm = require('vm');
// Run in a new empty context
let context = vm.createContext();
let result = vm.runInContext('"passed";', context);
assert.strictEqual('passed', result);
assert.strictEqual(result, 'passed');

// Create a new pre-populated context
context = vm.createContext({ 'foo': 'bar', 'thing': 'lala' });
Expand Down