Skip to content

test: add test for socket.end callback #24087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ajido wants to merge 2 commits into from
Closed

test: add test for socket.end callback #24087

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2761623
test: add test for socket.end callback
Ajido Nov 4, 2018
08df2c1
remove unnecessary code
Ajido Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unnecessary code
  • Loading branch information
@Ajido
Ajido committed Nov 5, 2018
commit 08df2c17725d6d721e0b8f86526849ca2be8d78b
17 changes: 4 additions & 13 deletions test/parallel/test-net-socket-end-callback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const net = require('net');

let ends = 0;

const server = net.createServer((socket) => {
socket.resume();
}).unref();
Expand All @@ -17,15 +14,9 @@ server.listen(common.mustCall(() => {
});
};

const cb = () => {
ends++;
};
const cb = common.mustCall(() => {}, 3);

connect(common.mustCall(cb));
connect('foo', common.mustCall(cb));
connect('foo', 'utf8', common.mustCall(cb));
connect(cb);
connect('foo', cb);
connect('foo', 'utf8', cb);
}));

process.on('exit', () => {
assert.strictEqual(ends, 3);
});