Skip to content

remove unused catch bindings #24079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 12 commits into from
Nov 6, 2018
Merged

remove unused catch bindings #24079

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9d68e56
fs: remove unused catch bindings
cjihrig Nov 4, 2018
39a0272
assert: remove unused catch bindings
cjihrig Nov 4, 2018
57c5c7d
events: remove unused catch bindings
cjihrig Nov 4, 2018
81b335d
bootstrap: remove unused catch bindings
cjihrig Nov 4, 2018
a64ca71
esm: remove unused catch bindings
cjihrig Nov 4, 2018
fcb8bf1
inspector: remove unused catch bindings
cjihrig Nov 4, 2018
30f58b9
v8_prof_polyfill: remove unused catch bindings
cjihrig Nov 4, 2018
ab14ad1
querystring: remove unused catch bindings
cjihrig Nov 4, 2018
a7ba5fa
repl: remove unused catch bindings
cjihrig Nov 4, 2018
a74b4a0
test: remove unused catch bindings
cjihrig Nov 4, 2018
5407690
benchmark: remove unused catch bindings
cjihrig Nov 4, 2018
5e6193f
tools: lint for unused catch bindings
cjihrig Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
v8_prof_polyfill: remove unused catch bindings 
PR-URL: #24079
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed Nov 6, 2018
commit 30f58b92ee88a2c90ab570d68f4ff4628126b5f0
2 changes: 1 addition & 1 deletion lib/internal/v8_prof_polyfill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function macCppfiltNm(out) {
filtered = cp.spawnSync('c++filt', [ '-p' , '-i' ], {
input: entries.join('\n')
}).stdout.toString();
} catch (e) {
} catch {
return out;
}

Expand Down