Skip to content

[v8.x] backport assert: add rejects() and doesNotReject() #24019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 4 commits into from
Closed

[v8.x] backport assert: add rejects() and doesNotReject() #24019

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ee80bc
assert: add rejects() and doesNotReject()
feugy Jan 11, 2018
30bfd25
test: ensure failed assertions cause build to fail
not-an-aardvark Mar 28, 2018
c247052
assert: ensure .rejects() disallows sync throws
not-an-aardvark Mar 28, 2018
38ef81d
fixup: fix test no default message for assert.fail() in 8.x
MylesBorins Nov 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: fix test no default message for assert.fail() in 8.x
  • Loading branch information
@MylesBorins
MylesBorins committed Nov 3, 2018
commit 38ef81d4c82249c30020daee6ff8ffeb5fce8b56
2 changes: 1 addition & 1 deletion test/parallel/test-assert-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ common.crashOnUnhandledRejection();

(async () => {
await assert.rejects(
async () => assert.fail(),
async () => assert.fail('Failed'),
common.expectsError({
code: 'ERR_ASSERTION',
type: assert.AssertionError,
Expand Down