Skip to content

win: add prompt to tools installation script #23987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joaocgreis wants to merge 4 commits into from
+24 −1
Closed

win: add prompt to tools installation script #23987

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8525d6
win: clarify Boxstarter behavior on install tools
ferventcoder Oct 31, 2018
91d99c6
fixup: address feedback from Trott
joaocgreis Oct 31, 2018
23c02c0
win: add prompt to tools installation script
joaocgreis Oct 31, 2018
078745a
fixup for d8525d6a2003a78c4977c68c623a7ea66506e959
joaocgreis Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
win: clarify Boxstarter behavior on install tools 
Clarify the behavior of what Boxstarter may do when it runs on a box
to install all the necessary tools so that there are no surprises to
the end user when the script is run.

Currently there is no interface that warns the user that Boxstarter
will reboot the machine possibly multiple times depending on how many
dependencies need to be installed and doesn't mention a need to disable
UAC. For folks who see what may look like a reboot loop, we feel it is
necessary to make them aware that UAC will be disabled and they will
need to take action to re-enable UAC manually if they interfere/stop
the script from finishing.
  • Loading branch information
@ferventcoder @joaocgreis
ferventcoder authored and joaocgreis committed Oct 31, 2018
commit d8525d6a2003a78c4977c68c623a7ea66506e959
18 changes: 17 additions & 1 deletion tools/msvs/install_tools/install_tools.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,23 @@ echo script is at your own risk. Please read the Chocolatey's legal terms of use
echo and the Boxstarter project license as well as how the community repository
echo for Chocolatey.org is maintained.
echo.
echo You can close this window to stop now.
pause

cls
echo !!!!!WARNING!!!!!
echo -----------------
echo Use of Boxstarter may reboot your box automatically multiple times. When
echo performing a reboot, Boxstarter will need to disable UAC to allow the
echo script to run immediately after the reboot. When the scripts have
echo completed, Boxstarter will re-enable UAC. If you prematurely stop the
echo process, UAC will need to be re-enabled manually.
echo.
echo Sometimes the scripts may install all necessary Windows Updates which
echo could cause a high number of reboots that appear to be a reboot loop when
echo in fact it is just a normal Windows Updates reboot cycle.
echo.
echo If this is not what you would like to occur, you can close this window
echo to stop now.
Copy link
Copy Markdown
Contributor

@ferventcoder ferventcoder Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can pull these two lines out since you reference this below.

pause

"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -NoProfile -InputFormat None -ExecutionPolicy Bypass -Command Start-Process '%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe' -ArgumentList '-NoProfile -InputFormat None -ExecutionPolicy Bypass -Command iex ((New-Object System.Net.WebClient).DownloadString(''https://boxstarter.org/bootstrapper.ps1'')); get-boxstarter -Force; Install-BoxstarterPackage -PackageName ''%~dp0\install_tools.txt''; Read-Host ''Type ENTER to exit'' ' -Verb RunAs