Skip to content

net: net.Server.listen() avoid operations on null when fail #23920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oyyd wants to merge 2 commits into from
Closed

net: net.Server.listen() avoid operations on null when fail #23920

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5764ae
net: `net.Server.listen()` avoid operations on `null` when fail
oyyd Oct 27, 2018
f58c0f1
fixup
oyyd Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@oyyd
oyyd committed Oct 30, 2018
commit f58c0f1c2e1fd49fd0f76c28ea7d75cb7fa65f9d
24 changes: 15 additions & 9 deletions test/parallel/test-net-server-listen-path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,20 @@ function randomPipePath() {

// Test should emit "error" events when listening fails.
{
const srv = net.createServer()
.listen({
path: tmpdir.path,
writableAll: true,
}, common.mustNotCall());
const handlePath = randomPipePath();
const srv1 = net.createServer().listen({ path: handlePath }, () => {
// As the handlePath is in use, binding to the same address again should
// make the server emit an 'EADDRINUSE' error.
const srv2 = net.createServer()
.listen({
path: handlePath,
writableAll: true,
}, common.mustNotCall());

srv.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'EADDRINUSE');
assert(/^listen EADDRINUSE: address already in use/.test(err.message));
}));
srv2.on('error', common.mustCall((err) => {
srv1.close();
assert.strictEqual(err.code, 'EADDRINUSE');
assert(/^listen EADDRINUSE: address already in use/.test(err.message));
}));
});
}