Skip to content

src: fix compiler warnings #23880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

src: fix compiler warnings #23880

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
211e40e
src: include util-inl.h in worker_agent.cc
addaleax Oct 25, 2018
107ca53
src: make model counter in `GetCPUInfo()` unsigned
addaleax Oct 25, 2018
7b0396c
src: remove unused variables
addaleax Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: make model counter in GetCPUInfo() unsigned 
This fixes a compiler warning about comparing against
the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant.
  • Loading branch information
@addaleax
addaleax committed Oct 25, 2018
commit 107ca5393ee65a7d8c79be4164c51f9bacba3fdd
2 changes: 1 addition & 1 deletion src/node_os.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ static void GetCPUInfo(const FunctionCallbackInfo<Value>& args) {
Local<Array> cpus = args[2].As<Array>();

Local<Value> model_argv[NODE_PUSH_VAL_TO_ARRAY_MAX];
int model_idx = 0;
unsigned int model_idx = 0;

for (i = 0, field_idx = 0; i < count; i++) {
uv_cpu_info_t* ci = cpu_infos + i;
Expand Down