Skip to content

[v10.x] Revert buffer crash #23875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 3 commits into from
Closed

[v10.x] Revert buffer crash #23875

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b431ad
src: remove function hasTextDecoder in encoding.js
chichiwang Oct 12, 2018
72ffab8
Revert "src: remove calls to deprecated v8 functions (IntegerValue)"
refack Oct 25, 2018
d39da71
buffer: test fix crash for invalid index types
addaleax Oct 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
buffer: test fix crash for invalid index types
  • Loading branch information
@addaleax @refack
addaleax authored and refack committed Oct 25, 2018
commit d39da714cf1d3ebdb224d5366dd4bda231059b86
21 changes: 21 additions & 0 deletions test/parallel/test-buffer-copy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,17 @@ let cntr = 0;
}
}

{
// Current behavior is to coerce values to integers.
b.fill(++cntr);
c.fill(++cntr);
const copied = b.copy(c, '0', '0', '512');
assert.strictEqual(copied, 512);
for (let i = 0; i < c.length; i++) {
assert.strictEqual(c[i], b[i]);
}
}

{
// copy c into b, without specifying sourceEnd
b.fill(++cntr);
Expand Down Expand Up @@ -144,3 +155,13 @@ assert.strictEqual(b.copy(c, 512, 0, 10), 0);
assert.strictEqual(c[i], e[i]);
}
}

// https://github.com/nodejs/node/issues/23668: Do not crash for invalid input.
c.fill('c');
b.copy(c, 'not a valid offset');
// Make sure this acted like a regular copy with `0` offset.
assert.deepStrictEqual(c, b.slice(0, c.length));

assert.throws(() => {
b.copy(c, { [Symbol.toPrimitive]() { throw new Error('foo'); } });
}, /foo/);