Skip to content

lib: modify NativeModule to use compileFunction #23837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryzokuken wants to merge 9 commits into
base: main
Choose a base branch
from
+33 −24
Open

lib: modify NativeModule to use compileFunction #23837

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc9f7e1
lib: modify NativeModule to use compileFunction
ryzokuken Oct 23, 2018
efc0892
fixup! lib: modify NativeModule to use compileFunction
ryzokuken Oct 23, 2018
19262a0
vm: report cache rejection in vm.compileFunction
ryzokuken Oct 24, 2018
9ec01a2
fixup! lib: modify NativeModule to use compileFunction
ryzokuken Oct 24, 2018
382e3e8
fixup! lib: modify NativeModule to use compileFunction
ryzokuken Oct 25, 2018
72d542b
fixup! lib: modify NativeModule to use compileFunction
ryzokuken Oct 25, 2018
690fe8b
fixup! lib: modify NativeModule to use compileFunction
ryzokuken Oct 25, 2018
ab4d9ad
fixup! lib: modify NativeModule to use compileFunction
ryzokuken Oct 27, 2018
d2dcd54
fixup! lib: modify NativeModule to use compileFunction
ryzokuken Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
vm: report cache rejection in vm.compileFunction 
Add functionality in vm.compileFunction/CompileFunction to report if
cache data was provided yet rejected by v8.
  • Loading branch information
@ryzokuken
ryzokuken committed Oct 24, 2018
commit 19262a0d4ac39dacc96af990b4642c69a49c39a9
11 changes: 11 additions & 0 deletions src/node_contextify.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,12 +1099,23 @@ void ContextifyContext::CompileFunction(
env->cached_data_string(),
buf.ToLocalChecked()).IsNothing()) return;
}

// Report if cache was produced.
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into the implementation a bit, and I wonder if we can just wrap ScriptCompiler::CreateCodeCacheForFunction in another binding that takes a function as argument? That way we can just manipulate the return values in the JS land, and also enable the code cache generator to use the exact function compiled to generate the cache if we simply return fn in NativeModule.prototype.compile - also, we don't actually need that argument handling complexity in the compileFunction C++ binding, vm.compileFunction can handle produce_cached_data in JS land and NativeModule.prototype.compile doesn't even need it at all.

Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I just noticed that the docs of vm.compileFunction did not mention its return value. Is that intentional?

Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Oct 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and the returned values are not tested either?)

if (fun->Set(
parsing_context,
env->cached_data_produced_string(),
Boolean::New(isolate, cached_data_produced)).IsNothing()) return;
}

// Report if cache was rejected.
if (options == ScriptCompiler::kConsumeCodeCache) {
if (fun->Set(parsing_context,
env->cached_data_rejected_string(),
Boolean::New(isolate, source.GetCachedData()->rejected))
.IsNothing())
return;
}
Comment thread
ryzokuken marked this conversation as resolved.

args.GetReturnValue().Set(fun);
}

Expand Down