Skip to content

module: allow passing a directory to createRequireFromPath #23818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gillesdemey wants to merge 6 commits into from
Closed

module: allow passing a directory to createRequireFromPath #23818

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a734696
module: allow passing a directory to createRequireFromPath
gillesdemey Oct 22, 2018
676cc00
module: fix windows path separators
gillesdemey Oct 22, 2018
c2eff11
test: make test-module-create-require-from-directory pass on Windows
gillesdemey Oct 22, 2018
2b1f48e
test: add a negative test to test-module-create-require-from-directory
gillesdemey Nov 28, 2018
5942747
fixup: doc change
MylesBorins Apr 25, 2019
9ec4cb8
fixup: notes from review
MylesBorins Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: notes from review
  • Loading branch information
@MylesBorins
MylesBorins committed Apr 30, 2019
commit 9ec4cb8d607945be44ddf7647382b0d40cbf3db4
7 changes: 3 additions & 4 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,9 +826,8 @@ Module.runMain = function() {

Module.createRequireFromPath = (filename) => {
// Allow a directory to be passed as the filename
const normalized = path.win32.normalize(filename);
const trailingSlash = normalized.charCodeAt(normalized.length - 1) ===
CHAR_BACKWARD_SLASH;
const trailingSlash =
filename.endsWith(path.sep) || path.sep !== '/' && filename.endsWith('\\');

const proxyPath = trailingSlash ?
path.join(filename, 'noop.js') :
Comment thread
guybedford marked this conversation as resolved.
Outdated
Expand All @@ -837,7 +836,7 @@ Module.createRequireFromPath = (filename) => {
const m = new Module(proxyPath);
m.filename = proxyPath;

m.paths = Module._nodeModulePaths(path.dirname(proxyPath));
m.paths = Module._nodeModulePaths(m.path);
return makeRequireFunction(m);
};

Expand Down