Skip to content

zlib: do not leak on destroy #23734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mafintosh wants to merge 4 commits into from
Closed

zlib: do not leak on destroy #23734

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1055e3
zlib: do not leak on destroy
mafintosh Oct 18, 2018
91cdb3d
add @mcollina's test case
mafintosh Oct 22, 2018
9f7b2ce
add close in ondata test
mafintosh Oct 22, 2018
6a34ccd
use Buffer.alloc instead of allocUnsafe
mafintosh Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use Buffer.alloc instead of allocUnsafe
  • Loading branch information
@mafintosh
mafintosh committed Oct 23, 2018
commit 6a34ccdd515ca4c053a8abf85ce39ba19b99aae6
2 changes: 1 addition & 1 deletion test/parallel/test-zlib-close-in-ondata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const common = require('../common');
const zlib = require('zlib');

const ts = zlib.createGzip();
const buf = Buffer.allocUnsafe(1024 * 1024 * 20);
const buf = Buffer.alloc(1024 * 1024 * 20);

ts.on('data', common.mustCall(() => ts.close()));
ts.end(buf);