Skip to content

doc: improve README.md #23705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

doc: improve README.md #23705

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ffdb44
doc: improve README.md
Trott Oct 17, 2018
9acb55b
fixup! doc: improve README.md
Trott Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: improve README.md 
Make text more concise and remove some use of passive voice.
  • Loading branch information
@Trott
Trott committed Oct 17, 2018
commit 3ffdb4496678f36bae93aa18e2c62f70a8414ea9
8 changes: 3 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,7 @@ When in doubt, please do send us a report.

## Current Project Team Members

The Node.js project team comprises a group of core collaborators and a sub-group
that forms the _Technical Steering Committee_ (TSC) which governs the project.
For more information about the governance of the Node.js project, see
For information about the governance of the Node.js project, see
[GOVERNANCE.md](./GOVERNANCE.md).

### TSC (Technical Steering Committee)
Expand Down Expand Up @@ -592,7 +590,7 @@ Node.js releases are signed with one of the following GPG keys:
* **Rod Vagg** <rod@vagg.org>
`DD8F2338BAE7501E3DD5AC78C273792F7D83545D`

The full set of trusted release keys can be imported by running:
To import the full set of trusted release keys:

```shell
gpg --keyserver pool.sks-keyservers.net --recv-keys 94AE36675C464D64BAFA68DD7434390BDBE9B9C5
Expand All @@ -608,7 +606,7 @@ gpg --keyserver pool.sks-keyservers.net --recv-keys DD8F2338BAE7501E3DD5AC78C273
See the section above on [Verifying Binaries](#verifying-binaries) for how to
use these keys to verify a downloaded file.

Previous releases may also have been signed with one of the following GPG keys:
Other keys used to sign some previous releases include:
Copy link
Copy Markdown
Member

@addaleax addaleax Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: include … we should be clear on whether this is an exhaustive list or not. The previous wording sounded to me like it is?

Copy link
Copy Markdown
Member

@jasnell jasnell Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's an exhaustive list.

Copy link
Copy Markdown
Member Author

@Trott Trott Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I can remove include?: Other keys used to sign some previous releases:


* **Chris Dickinson** <christopher.s.dickinson@gmail.com>
`9554F04D7259F04124DE6B476D5A82AC7E37093B`
Expand Down