Skip to content

n-api: make per-Context-ness of napi_env explicit #23689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

n-api: make per-Context-ness of napi_env explicit #23689

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fe948d
n-api: make per-`Context`-ness of `napi_env` explicit
addaleax Oct 16, 2018
2f3c078
fixup! n-api: make per-`Context`-ness of `napi_env` explicit
addaleax Oct 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
n-api: make per-Context-ness of napi_env explicit 
Because instances of `napi_env` are created on a per-global-object
basis and because since most N-API functions refer to builtin JS
objects, `napi_env` is essentially in 1:1 correspondence with
`v8::Context`.

This was not clear from the implementation by itself, but has
emerged from conversations with the N-API team.

This patch changes the `napi_env` implementation to:

- Actually store the `v8::Context` it represents.
- Provide more direct access to the `node::Environment`
  to which the `Context` belongs.
- Do not store the `uv_loop_t*` explicitly, since it can be
  inferred from the `node::Environment` and we actually
  have an N-API method for that.
- Replace calls to `isolate->GetCurrentContext()` with
  the more appropriate `napi_env` `Context`.
- Implement a better (although not perfect) way of cleaning
  up `napi_env` instances.
  • Loading branch information
@addaleax
addaleax committed Oct 21, 2018
commit 3fe948d1beeffe7d9fcd5e957c2ccb4ca3db144b
Loading