Skip to content

src: refacor MallocedBuffer to it's usage scope #23641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
refack wants to merge 19 commits into from
Closed

src: refacor MallocedBuffer to it's usage scope #23641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3ab4146
deps: cherry-pick b0af309 from upstream V8
addaleax Oct 10, 2018
849aa1e
lib: migrate to getOptions in loaders.js
rxiayth Oct 12, 2018
c24e963
test: improve test coverage for fs module
leomoreno Oct 12, 2018
9f7e3a4
src: reduce platform worker barrier lifetime
ofrobots Oct 11, 2018
64d65ed
test: fix `assert.strictEqual` arguments in test/parallel/test-c-ares.js
jungkumseok Oct 12, 2018
f0c5c96
repl: remove unused variable e from try catch
khalidadil Oct 12, 2018
478fe0a
test: fix order of values in test assertions
jehaines Oct 12, 2018
dee9d27
test: fix http local address test assertion
widatama Oct 12, 2018
c301518
repl: remove unused variable from try catch
mmisiarek Oct 12, 2018
0005846
test: replace assert.throws w/ common.expectsError
aeisenberg Oct 12, 2018
84b21eb
test: strictEqual correct order for http-information-processing test
ivansieder Oct 12, 2018
a239270
test: fix assert.strictEqual argument order
andy-ganchrow Oct 12, 2018
68b4637
lib: remove unused 'e' from catch
pdxmholmes Oct 12, 2018
767d4da
test: swap assert.strictEqual args to actual, expected
epeden Oct 12, 2018
657ee7b
test: fix incorrect ordering of args in assert.strictEqual()
mdaum Oct 12, 2018
1c73990
test: correct assert test
rmarkins-godaddy Oct 12, 2018
8691d8f
test: remove unused e variable in catch statement
DennyScott Oct 12, 2018
d16f098
src: refacor `MallocedBuffer` to it's usage scope
refack Oct 13, 2018
5837d36
src: malloced_unique_ptr & make_malloced_unique
refack Oct 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: reduce platform worker barrier lifetime 
Minor cleanup in the lifetime for the platform worker initialization
synchronization barrier.

PR-URL: #23419
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@ofrobots
ofrobots committed Oct 13, 2018
commit 9f7e3a404096db60438f6dc305b0a5fa4ecddae7
15 changes: 9 additions & 6 deletions src/node_platform.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,17 +167,20 @@ class WorkerThreadsTaskRunner::DelayedTaskScheduler {
};

WorkerThreadsTaskRunner::WorkerThreadsTaskRunner(int thread_pool_size) {
Mutex::ScopedLock lock(platform_workers_mutex_);
pending_platform_workers_ = thread_pool_size;
Mutex platform_workers_mutex;
ConditionVariable platform_workers_ready;

Mutex::ScopedLock lock(platform_workers_mutex);
int pending_platform_workers = thread_pool_size;

delayed_task_scheduler_.reset(
new DelayedTaskScheduler(&pending_worker_tasks_));
threads_.push_back(delayed_task_scheduler_->Start());

for (int i = 0; i < thread_pool_size; i++) {
PlatformWorkerData* worker_data = new PlatformWorkerData{
&pending_worker_tasks_, &platform_workers_mutex_,
&platform_workers_ready_, &pending_platform_workers_, i
&pending_worker_tasks_, &platform_workers_mutex,
&platform_workers_ready, &pending_platform_workers, i
};
std::unique_ptr<uv_thread_t> t { new uv_thread_t() };
if (uv_thread_create(t.get(), PlatformWorkerThread,
Expand All @@ -189,8 +192,8 @@ WorkerThreadsTaskRunner::WorkerThreadsTaskRunner(int thread_pool_size) {

// Wait for platform workers to initialize before continuing with the
// bootstrap.
while (pending_platform_workers_ > 0) {
platform_workers_ready_.Wait(lock);
while (pending_platform_workers > 0) {
platform_workers_ready.Wait(lock);
}
}

Expand Down
4 changes: 0 additions & 4 deletions src/node_platform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,6 @@ class WorkerThreadsTaskRunner {
std::unique_ptr<DelayedTaskScheduler> delayed_task_scheduler_;

std::vector<std::unique_ptr<uv_thread_t>> threads_;

Mutex platform_workers_mutex_;
ConditionVariable platform_workers_ready_;
int pending_platform_workers_;
};

class NodePlatform : public MultiIsolatePlatform {
Expand Down