Skip to content

[v10.x backport] test: refactor common.ddCommand() #23630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 16 commits into from
Closed

[v10.x backport] test: refactor common.ddCommand() #23630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6d151ad
tls: make StreamWrap work correctly in "drain" callback
oyyd Oct 7, 2018
f2b4734
src: revert removal of SecureContext `_external` getter
dyatlov Jul 8, 2018
ad59bbd
lib: http server, friendly error messages
sagitsofan Sep 20, 2018
736d6d1
src: improve SSL version extraction logic
gireeshpunathil Sep 24, 2018
2218a38
src: fix bug in MallocedBuffer constructor
tniessen Oct 12, 2018
4b0c0f1
doc: revise security-reporting text in README
Trott Oct 10, 2018
f6a2af5
test: fixing assertion value order
joesepi Oct 12, 2018
4089a55
test: fix assert.strictEqual argument order
et4891 Oct 12, 2018
584470c
test: improve test-gc-http-client-connaborted
lundibundi Oct 1, 2018
0d7328d
test: improve test-gc-http-client-onerror
lundibundi Oct 1, 2018
35f9218
test: move some gc tests back to parallel/, unmark flaky
addaleax Oct 9, 2018
e86b6aa
zlib: generate error code names in C++
addaleax Oct 7, 2018
3a533d6
doc: describe SNI host name format
sam-github Oct 9, 2018
7c9b37e
http: reduce duplicated code for cleaning parser
starkwang Oct 9, 2018
79a2b00
test: refactor common.ddCommand()
Trott Oct 10, 2018
ea510a6
test: rename common.ddCommand()
Trott Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: move some gc tests back to parallel/, unmark flaky 
These should no longer be flaky after the libuv update.

Refs: #23336

PR-URL: #23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@addaleax @Trott
addaleax authored and Trott committed Oct 13, 2018
commit 35f9218b6def0808826ea412460d8bce5b00495d
0 ...ential/test-gc-http-client-connaborted.js → ...rallel/test-gc-http-client-connaborted.js
View file
Open in desktop
File renamed without changes.
0 ...sequential/test-gc-http-client-onerror.js → test/parallel/test-gc-http-client-onerror.js
View file
Open in desktop
File renamed without changes.
0 ...sequential/test-gc-http-client-timeout.js → test/parallel/test-gc-http-client-timeout.js
View file
Open in desktop
File renamed without changes.
0 test/sequential/test-gc-net-timeout.js → test/parallel/test-gc-net-timeout.js
View file
Open in desktop
File renamed without changes.
11 changes: 0 additions & 11 deletions test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,8 @@ prefix sequential
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands
# on Node.js.
test-fs-readfile-tostring-fail: PASS, FLAKY
# https://github.com/nodejs/node/issues/23066
test-gc-http-client-timeout: PASS, FLAKY
# https://github.com/nodejs/node/issues/22336
test-gc-http-client: PASS,FLAKY
# https://github.com/nodejs/node/issues/23067
test-gc-net-timeout: PASS,FLAKY
# https://github.com/nodejs/node/issues/23089
test-gc-http-client-onerror: PASS,FLAKY
# https://github.com/nodejs/node/issues/23219
test-gc-http-client-connaborted: PASS,FLAKY

[$system==win32]
# https://github.com/nodejs/node/issues/22327
Expand Down