Skip to content

test: reversed 1st and 2nd arguments for assert.strictEqual() #23617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vchoubey08 wants to merge 1 commit into from
Closed

test: reversed 1st and 2nd arguments for assert.strictEqual() #23617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: reversed 1st and 2nd arguments for assert.strictEqual()
  • Loading branch information
@vchoubey08
vchoubey08 committed Oct 12, 2018
commit d0343ec0d2c1044211db0923508fd9aa04eb0bd2
2 changes: 1 addition & 1 deletion test/parallel/test-memory-usage-emfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ while (files.length < 256)
files.push(fs.openSync(__filename, 'r'));

const r = process.memoryUsage();
assert.strictEqual(true, r.rss > 0);
assert.strictEqual(r.rss > 0, true);
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Oct 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This could be better written as assert(r.rss > 0).