Skip to content

crypto: move field initialization to class #23610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theholla wants to merge 2 commits into from
Closed

crypto: move field initialization to class #23610

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59a0962
crypto: move field initialization to class
Oct 12, 2018
d2e44f5
crypto: complete ClientHelloParser initializers
theholla Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
crypto: complete ClientHelloParser initializers
  • Loading branch information
@theholla
theholla committed Oct 12, 2018
commit d2e44f58b1fc2b7a752697a51fd5823bcb2bc1a4
20 changes: 10 additions & 10 deletions src/node_crypto_clienthello.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ class ClientHelloParser {
inline int ocsp_request() const { return ocsp_request_; }

private:
uint8_t session_size_ = 0;
const uint8_t* session_id_ = nullptr;
uint8_t session_size_;
const uint8_t* session_id_;
bool has_ticket_;
uint8_t servername_size_ = 0;
const uint8_t* servername_ = nullptr;
int ocsp_request_ = 0;
uint8_t servername_size_;
const uint8_t* servername_;
int ocsp_request_;

friend class ClientHelloParser;
};
Expand Down Expand Up @@ -111,11 +111,11 @@ class ClientHelloParser {
size_t frame_len_ = 0;
size_t body_offset_ = 0;
size_t extension_offset_ = 0;
uint8_t session_size_;
const uint8_t* session_id_;
uint16_t servername_size_;
const uint8_t* servername_;
uint8_t ocsp_request_;
uint8_t session_size_ = 0;
const uint8_t* session_id_ = nullptr;
uint16_t servername_size_ = 0;
const uint8_t* servername_ = nullptr;
uint8_t ocsp_request_ = 0;
uint16_t tls_ticket_size_ = -1;
const uint8_t* tls_ticket_ = nullptr;
};
Expand Down