Skip to content

test: re-order strictEqual paramater calls #23607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tracer99 wants to merge 1 commit into from
Closed

test: re-order strictEqual paramater calls #23607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: re-order strictEqual paramater calls
  • Loading branch information
@ptichonczuk-tc
ptichonczuk-tc committed Oct 12, 2018
commit 44ec52469261e3c2d1570f65d46eca5abc844d11
12 changes: 6 additions & 6 deletions test/parallel/test-net-reconnect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const server = net.createServer(function(socket) {

socket.on('close', function(had_error) {
console.log(`SERVER had_error: ${JSON.stringify(had_error)}`);
assert.strictEqual(false, had_error);
assert.strictEqual(had_error, false);
});
});

Expand All @@ -61,7 +61,7 @@ server.listen(0, function() {
client.on('data', function(chunk) {
client_recv_count += 1;
console.log(`client_recv_count ${client_recv_count}`);
assert.strictEqual('hello\r\n', chunk);
assert.strictEqual(chunk, 'hello\r\n');
console.error('CLIENT: calling end', client._writableState);
client.end();
});
Expand All @@ -73,7 +73,7 @@ server.listen(0, function() {

client.on('close', function(had_error) {
console.log('CLIENT disconnect');
assert.strictEqual(false, had_error);
assert.strictEqual(had_error, false);
if (disconnect_count++ < N)
client.connect(server.address().port); // reconnect
else
Expand All @@ -82,7 +82,7 @@ server.listen(0, function() {
});

process.on('exit', function() {
assert.strictEqual(N + 1, disconnect_count);
assert.strictEqual(N + 1, client_recv_count);
assert.strictEqual(N + 1, client_end_count);
assert.strictEqual(disconnect_count, N + 1);
assert.strictEqual(client_recv_count, N + 1);
assert.strictEqual(client_end_count, N + 1);
});