Skip to content

test: adding test coverage for SourceTextModule.evaluate #23595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaltepeter wants to merge 4 commits into from
Closed

test: adding test coverage for SourceTextModule.evaluate #23595

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
704bc13
test: adding test coverage for SourceTextModule.evaluate
kaltepeter Oct 12, 2018
e0098f9
fixup: fixing lint line length
kaltepeter Oct 12, 2018
b5191a5
fixup: fixing line spacing
kaltepeter Oct 12, 2018
5f9d6cd
fixup: fix spacing
kaltepeter Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: adding test coverage for SourceTextModule.evaluate 
This checks that invalid option throws an error.
  • Loading branch information
@kaltepeter
kaltepeter committed Oct 12, 2018
commit 704bc13f88b9d798915c0faa98e9d3d5a02eebe2
8 changes: 8 additions & 0 deletions test/parallel/test-vm-module-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,14 @@ async function checkModuleState() {
message: 'Module status must be one of instantiated, evaluated, and errored'
});

await expectsRejection(async () => {
const m = new SourceTextModule('');
await m.evaluate(false);
}, {
code: 'ERR_INVALID_ARG_TYPE',
message: 'The "options" argument must be of type Object. Received type boolean'
});

await expectsRejection(async () => {
const m = await createEmptyLinkedModule();
await m.evaluate();
Expand Down